Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jp_JP] Add .readthedocs.yaml for release-2.5 #919

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[jp_JP] Add .readthedocs.yaml for release-2.5 #919

merged 2 commits into from
Oct 30, 2023

Conversation

satota2
Copy link
Contributor

@satota2 satota2 commented Oct 30, 2023

This patch adds .readthedocs.yaml for Japanese translation on release-2.5.

Related Issue:

@satota2
[jp_JP] Add .readthedocs.yaml for release-2.5
b707dbb 
Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
@satota2 satota2 requested review from a team as code owners October 30, 2023 05:28
@satota2 satota2 requested a review from a team October 30, 2023 05:28
@satota2 satota2 changed the title [jp_JP] Add .readthedocs.yaml for release-2.5 WIP [jp_JP] Add .readthedocs.yaml for release-2.5 Oct 30, 2023
@satota2
[ja_JP] Bump requirements.txt to Fabric repo
9202b0e 
Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
@satota2 satota2 changed the title WIP [jp_JP] Add .readthedocs.yaml for release-2.5 [jp_JP] Add .readthedocs.yaml for release-2.5 Oct 30, 2023
@satota2
Copy link
Contributor Author

satota2 commented Oct 30, 2023 •
edited
Loading

Hello @ryjones
As mentioned in the Issue #918, the build fails without a configuration file in ReadTheDocs.
So, for ja_JP, I have set the .readthedocs.yaml path on the ReadTheDocs side and created a patch to add the configuration file for release-2.5 (this PR).
It seems to be working well as far as the build in the PR.

May I ask you to review and merge this PR?

@ryjones ryjones merged commit baac65f into hyperledger:release-2.5 Oct 30, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satota2 @ryjones