Fix GatewayException.printStackTrace(PrintStream) #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The printStackTrace() implementation taking a PrintStream (rather than a PrintWriter) in the Java GatewayException class failed to print output. This was due to the PrinterWriter used to wrap the supplied PrintStream not being flushed. This change calls the PrintStream overload with unit tests, instead of the PrintWriter overload (to which it defers) to ensure both variants behave correctly. The printStackTrace() implementation is updated to correctly flush the PrintWriter used internally to wrap the supplied PrintStream. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
andrew-coleman
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The printStackTrace() implementation taking a PrintStream (rather than a PrintWriter) in the Java GatewayException class failed to print output. This was due to the PrinterWriter used to wrap the supplied PrintStream not being flushed.
This change calls the PrintStream overload with unit tests, instead of the PrintWriter overload (to which it defers) to ensure both variants behave correctly. The printStackTrace() implementation is updated to correctly flush the PrintWriter used internally to wrap the supplied PrintStream.