Fix Node build break on typescript-eslint #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
typescript-eslint
branch
from
eff681d
to
0cb34ff
Compare
typescript-eslint v8.14.0 and earlier were broken by an implementation change in ESLint v9.15.0. This change makes use of package-lock.json files to allow resolved dependency versions to be moved forwards in a more controlled manner, and minimise the chances of unexpected breakages like this in future. - Include package-lock.json files to stabilize the Node dependency versions resolved across builds. - Change Makefile targets to use `npm ci` instead of `npm install` so that package-lock.json files are honored when resolving dependencies. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
typescript-eslint
branch
from
0cb34ff
to
39e33cf
Compare
andrew-coleman
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript-eslint v8.14.0 and earlier were broken by an implementation change in ESLint v9.15.0. This change makes use of package-lock.json files to allow resolved dependency versions to be moved forwards in a more controlled manner, and minimise the chances of unexpected breakages like this in future.
npm ciinstead ofnpm installso that package-lock.json files are honored when resolving dependencies.