Fix mockery install to work on Apple Silicon Macs #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL used to download the Mockery binary is composed using the current hardware platform string. For Apple Silicon Macs, this is `aarch64`, whereas the Mockery binary uses `arm64`. This change uses `arm64` in place of `aarch64` as the hardware platform to build the Mockery download URL. The version of Mockery is also updated. Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
andrew-coleman
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL used to download the Mockery binary is composed using the current hardware platform string. For Apple Silicon Macs, this is
aarch64, whereas the Mockery binary usesarm64.This change uses
arm64in place ofaarch64as the hardware platform to build the Mockery download URL.The version of Mockery is also updated.