Fix testing on non-Intel CPU #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
bvavala
added
bug
| @@ -30,7 +30,7 @@ ARG UBUNTU_VERSION | |||
| ARG UBUNTU_NAME | |||
|
|
|||
| # config/build params (part 2) | |||
| ARG SGX=2.12 | |||
| ARG SGX=2.16 | |||
There was a problem hiding this comment.
Is this version the most recent one we can get without "compatibility" issues / api changes?
mbrandenburger
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the SGX SDK and SSL packages and enables the SKIP_INTELCPU_CHECK flag.
SGX SSL aborts when it's not used on Intel CPUs, even in SIM mode.
However, more recent versions (which require an SDK upgrade) allow to build the package by excluding that check.
Additionally, the PR enables SGX SSL tests to spot these issues early on, since these are only executed when the docker containers need to be rebuilt.