Feature/integrate with cc tools #779
Open
+583
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Closed
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
39d2366
to
a064eb0
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Oct 11, 2024
mbrandenburger
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @osamamagdy this is pretty cool! Let's shape it a bit more!
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
92e4665
to
1ec09a9
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
87db6e1
to
ae668f1
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Oct 23, 2024
|
@osamamagdy I think you can tell staticcheck to ignore the deprecated use issue and thus make CI passing. You find the documentation here: https://staticcheck.dev/docs/configuration/#ignoring-problems |
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
…osamamagdy/fabric-private-chaincode into feature/integrate-with-cc-tools
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Nov 6, 2024
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
f9e9d15
to
ae77fce
Compare
Signed-off-by: Osama Magdy <59124937+osamamagdy@users.noreply.github.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
9eab2e5
to
9c485b8
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Nov 22, 2024
| ``` | ||
|
|
||
| **Note:** If you're inside the dev environment, you don't need the `sudo` permissions and don't need to `chown` the directory. | ||
| The chaincode code structure is different than normal chaincode as it's using the cc-tools framework. |
There was a problem hiding this comment.
I think you need to add an enter here ... I don't think that last sentence is part of the note, correct?
munapower
requested changes
Nov 22, 2024
| In `$FPC_PATH/samples/chaincode/cc-tools-demo` directory, to build the chaincode and package it as docker image, execute: | ||
|
|
||
| ```bash | ||
| make |
There was a problem hiding this comment.
So I would add a note here that for those that have arm-based computers they should use the method recommended in the main readme for building both the cc-tools-demo chaincode as well as ercc
| Open a new terminal and connect to the `fpc-development-go-support` container by running | ||
|
|
||
| ```bash | ||
| docker exec -it fpc-development-go-support /bin/bash |
There was a problem hiding this comment.
are you sure about the name of the environment? I had to change fpc-development-go-support to fpc-development-main .... I am guessing you are using a branch and maybe that is why the difference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a tutorial on how to integrate with cc-tools project, specially using the cc-tools-demo project
Which issue(s) this PR fixes:
Fixes the LFX mentorship project Hyperledger Fabric CC-Tools Support for Fabric Private Chaincode