vendor directory

[pfi79]

Current Status

Currently there is a vendor folder

I have a question: why is it needed?

It is written in the documentation for vendoring:

Vendoring may be used to allow interoperation with older versions of Go, or to ensure that all files used for a build are stored in a single file tree.

After trying to update github.com/prometheus/client_golang, the peer and orderer programs in docker stopped building. However, if the vendor folder is removed, everything builds fine.

Goal

It seems to me that this is already redundant in the fabric project.
And it can be deleted.

Solution

Try deleting the vendor folder and check that no functionality has fallen off.

[C0rWin]

After trying to update github.com/prometheus/client_golang, the peer and orderer programs in docker stopped building. However, if the vendor folder is removed, everything builds fine.

Can you put here an error?

[pfi79]

After trying to update github.com/prometheus/client_golang, the peer and orderer programs in docker stopped building. However, if the vendor folder is removed, everything builds fine.

Can you put here an error?

#5032

#4052

vendor/github.com/prometheus/client_golang/prometheus/registry.go:62:15: undefined: NewGoCollector

a command that causes an error

make docker