Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete folder vendor #5039

Closed
wants to merge 1 commit into from
Closed

delete folder vendor #5039

wants to merge 1 commit into from

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Oct 21, 2024

#5037

I think that the vendor folder is already unnecessary and can be deleted.
It is more of a hindrance.

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@pfi79 pfi79 requested a review from a team as a code owner October 21, 2024 11:50
@denyeart
Copy link
Contributor

Whether to include vendor directory or not was discussed early in the project. It was decided to check in the vendor folder to ensure all dependencies remain available for every version of Fabric. Basically it is the first Pro here:

https://stackoverflow.com/questions/47346607/is-it-best-practice-to-commit-the-vendor-directory

It's the only way to get truly reproducible builds, as it guards against upstream renames, deletes and commit history overwrites.

@denyeart denyeart closed this Oct 21, 2024
@pfi79 pfi79 deleted the delete-vendor branch October 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants