Validate the request #4588

yeasy · 2024-01-03T22:04:07Z

The patchset adds validation to the request before using it.

Change-Id: Ic6a7a65d6da289d84fe82c3f6e048e396b1f1a0e

Type of change

Improvement (improvement to code, performance, etc)

Description

The patchset adds validation to the request before using it.

This can help protect from malformed request.

Additional details

N/A

Related issues

N/A

Release Note

N/A

internal/pkg/gateway/commitstatus.go

C0rWin · 2024-01-17T21:09:09Z

    --- FAIL: TestCommitStatus/error_finding_transaction_status (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "FINDER_ERROR"
            	Test:       	TestCommitStatus/error_finding_transaction_status
            	Messages:   	error string
    --- FAIL: TestCommitStatus/returns_transaction_status (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/returns_transaction_status
    --- FAIL: TestCommitStatus/passes_channel_name_to_finder (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_channel_name_to_finder
    --- FAIL: TestCommitStatus/passes_transaction_ID_to_finder (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_transaction_ID_to_finder
    --- FAIL: TestCommitStatus/failed_policy_or_signature_check (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "POLICY_ERROR"
            	Test:       	TestCommitStatus/failed_policy_or_signature_check
            	Messages:   	error string
    --- FAIL: TestCommitStatus/passes_channel_name_to_policy_checker (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_channel_name_to_policy_checker
    --- FAIL: TestCommitStatus/context_timeout (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "context deadline exceeded"
            	Test:       	TestCommitStatus/context_timeout
            	Messages:   	error string
    --- FAIL: TestCommitStatus/context_canceled (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "context canceled"
            	Test:       	TestCommitStatus/context_canceled
            	Messages:   	error string

@yeasy I think you also need to update the tests to adjust to your changes.

yeasy · 2024-01-22T19:10:18Z

    --- FAIL: TestCommitStatus/error_finding_transaction_status (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "FINDER_ERROR"
            	Test:       	TestCommitStatus/error_finding_transaction_status
            	Messages:   	error string
    --- FAIL: TestCommitStatus/returns_transaction_status (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/returns_transaction_status
    --- FAIL: TestCommitStatus/passes_channel_name_to_finder (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_channel_name_to_finder
    --- FAIL: TestCommitStatus/passes_transaction_ID_to_finder (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_transaction_ID_to_finder
    --- FAIL: TestCommitStatus/failed_policy_or_signature_check (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "POLICY_ERROR"
            	Test:       	TestCommitStatus/failed_policy_or_signature_check
            	Messages:   	error string
    --- FAIL: TestCommitStatus/passes_channel_name_to_policy_checker (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_channel_name_to_policy_checker
    --- FAIL: TestCommitStatus/context_timeout (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "context deadline exceeded"
            	Test:       	TestCommitStatus/context_timeout
            	Messages:   	error string
    --- FAIL: TestCommitStatus/context_canceled (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "context canceled"
            	Test:       	TestCommitStatus/context_canceled
            	Messages:   	error string

@yeasy I think you also need to update the tests to adjust to your changes.

Fixed now.

C0rWin · 2024-01-28T08:58:12Z

    --- FAIL: TestCommitStatus/error_finding_transaction_status (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "FINDER_ERROR"
            	Test:       	TestCommitStatus/error_finding_transaction_status
            	Messages:   	error string
    --- FAIL: TestCommitStatus/returns_transaction_status (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/returns_transaction_status
    --- FAIL: TestCommitStatus/passes_channel_name_to_finder (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_channel_name_to_finder
    --- FAIL: TestCommitStatus/passes_transaction_ID_to_finder (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_transaction_ID_to_finder
    --- FAIL: TestCommitStatus/failed_policy_or_signature_check (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "POLICY_ERROR"
            	Test:       	TestCommitStatus/failed_policy_or_signature_check
            	Messages:   	error string
    --- FAIL: TestCommitStatus/passes_channel_name_to_policy_checker (0.00s)
        commitstatus_test.go:140: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:140
            	Error:      	Received unexpected error:
            	            	rpc error: code = InvalidArgument desc = no identity provided
            	Test:       	TestCommitStatus/passes_channel_name_to_policy_checker
    --- FAIL: TestCommitStatus/context_timeout (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "context deadline exceeded"
            	Test:       	TestCommitStatus/context_timeout
            	Messages:   	error string
    --- FAIL: TestCommitStatus/context_canceled (0.00s)
        api_test.go:552: 
            	Error Trace:	/home/runner/work/fabric/fabric/internal/pkg/gateway/api_test.go:552
            	            				/home/runner/work/fabric/fabric/internal/pkg/gateway/commitstatus_test.go:135
            	Error:      	Error "rpc error: code = InvalidArgument desc = no identity provided" does not contain "context canceled"
            	Test:       	TestCommitStatus/context_canceled
            	Messages:   	error string

@yeasy I think you also need to update the tests to adjust to your changes.

Fixed now.

Checking with goimports
The following files contain goimports errors
internal/pkg/gateway/commitstatus_test.go
make: *** [Makefile:182: linter] Error 1
The goimports command 'goimports -l -w' must be run for these files
Error: Process completed with exit code 2.

thanks, almost there, a little nit, please make sure to also pass basic checks.

C0rWin · 2024-01-31T20:37:16Z

@yeasy hey, do you have any ETA whenever you will be able to finalize your PR?

The patchset adds validation to the request before using it. This can help protect from mal-formed request. Change-Id: Ic6a7a65d6da289d84fe82c3f6e048e396b1f1a0e Signed-off-by: Baohua Yang <yangbaohua@gmail.com> Signed-off-by: Baohua Yang <baohua.yang@oracle.com>

yeasy · 2024-02-01T17:31:59Z

commitstatus_test

Done! Let's see how it works.

yeasy requested a review from a team as a code owner January 3, 2024 22:04

yeasy force-pushed the validate_request branch from 6f48aec to 517d46a Compare January 3, 2024 22:04

C0rWin requested changes Jan 4, 2024

View reviewed changes

internal/pkg/gateway/commitstatus.go Outdated Show resolved Hide resolved

yeasy force-pushed the validate_request branch from 517d46a to e35180f Compare January 5, 2024 18:29

C0rWin requested changes Jan 5, 2024

View reviewed changes

internal/pkg/gateway/commitstatus.go Outdated Show resolved Hide resolved

internal/pkg/gateway/commitstatus.go Outdated Show resolved Hide resolved

internal/pkg/gateway/commitstatus.go Outdated Show resolved Hide resolved

yeasy force-pushed the validate_request branch from e35180f to abe23ca Compare January 17, 2024 16:42

yeasy force-pushed the validate_request branch 2 times, most recently from db2f5ea to 8c68f29 Compare January 22, 2024 19:11

Validate the request

a82dc92

The patchset adds validation to the request before using it. This can help protect from mal-formed request. Change-Id: Ic6a7a65d6da289d84fe82c3f6e048e396b1f1a0e Signed-off-by: Baohua Yang <yangbaohua@gmail.com> Signed-off-by: Baohua Yang <baohua.yang@oracle.com>

yeasy force-pushed the validate_request branch from 8c68f29 to a82dc92 Compare February 1, 2024 17:31

denyeart approved these changes Feb 8, 2024

View reviewed changes

denyeart merged commit 74cece9 into hyperledger:main Feb 8, 2024
14 checks passed

yeasy deleted the validate_request branch February 10, 2024 04:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate the request #4588

Validate the request #4588

yeasy commented Jan 3, 2024

C0rWin commented Jan 17, 2024 •

edited

Loading

yeasy commented Jan 22, 2024

C0rWin commented Jan 28, 2024

C0rWin commented Jan 31, 2024

yeasy commented Feb 1, 2024

Validate the request #4588

Validate the request #4588

Conversation

yeasy commented Jan 3, 2024

Type of change

Description

Additional details

Related issues

Release Note

C0rWin commented Jan 17, 2024 • edited Loading

yeasy commented Jan 22, 2024

C0rWin commented Jan 28, 2024

C0rWin commented Jan 31, 2024

yeasy commented Feb 1, 2024

C0rWin commented Jan 17, 2024 •

edited

Loading