Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/alecthomas/kingpin/v2 to v2.4.0 #5023

Closed
wants to merge 1 commit into from

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Oct 10, 2024

No description provided.

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@pfi79 pfi79 requested review from a team as code owners October 10, 2024 18:34
Flags:
--help Show context-sensitive help (also try --help-long and
--[no-]help Show context-sensitive help (also try --help-long and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is no-help?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, after upgrading the library. this prompt is now generated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image As I understand it, this is done to explicitly set some parameter to false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfi79
Copy link
Contributor Author

pfi79 commented Oct 10, 2024

@denyeart The author of this library is weakly supportive, which is what he wrote about. He himself switched to the kong library.

Perhaps we should get rid of it in fabric. Should I switch to cobra and viper, as is done in peer, or to the same kong?

@denyeart
Copy link
Contributor

@denyeart The author of this library is weakly supportive, which is what he wrote about. He himself switched to the kong library.

Perhaps we should get rid of it in fabric. Should I switch to cobra and viper, as is done in peer, or to the same kong?

From my memory kingpin was simpler than cobra, so I'd be ok leaving it on the older kingpin (no update) to keep things simple. If you really want to invest your time in an update to kong or cobra then I'd be fine with it, up to you.

@pfi79
Copy link
Contributor Author

pfi79 commented Oct 10, 2024

@denyeart The author of this library is weakly supportive, which is what he wrote about. He himself switched to the kong library.
Perhaps we should get rid of it in fabric. Should I switch to cobra and viper, as is done in peer, or to the same kong?

From my memory kingpin was simpler than cobra, so I'd be ok leaving it on the older kingpin (no update) to keep things simple. If you really want to invest your time in an update to kong or cobra then I'd be fine with it, up to you.

Okay, maybe sometime in the future.

@pfi79
Copy link
Contributor Author

pfi79 commented Oct 11, 2024

I'd be ok leaving it on the older kingpin (no update) to keep things simple

then I'm closing the pr?

@denyeart
Copy link
Contributor

Yes, let's close the PR. The command utilities have been very stable, and the no-help thing is confusing, let's keep current dependency.

@denyeart denyeart closed this Oct 11, 2024
@pfi79 pfi79 deleted the bump-kingpin branch October 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants