update Dockerfiles to remove the warnings #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denyeart
reviewed
Oct 17, 2024
images/orderer/Dockerfile
Outdated
| @@ -48,7 +48,7 @@ RUN make orderer GO_TAGS=${GO_TAGS} FABRIC_VER=${FABRIC_VER} | |||
| ############################################################################### | |||
|
|
|||
| ARG UBUNTU_VER | |||
| FROM ubuntu:${UBUNTU_VER} | |||
| FROM ubuntu:${UBUNTU_VER:-20.04} | |||
pfi79
force-pushed
the
update-dockerfile
branch
from
08e2dcb
to
a11dd91
Compare
denyeart
reviewed
Oct 18, 2024
images/baseos/Dockerfile
Outdated
| @@ -19,7 +19,7 @@ | |||
| ARG GO_VER | |||
| ARG UBUNTU_VER | |||
|
|
|||
| FROM ubuntu:${UBUNTU_VER} as base | |||
| FROM ubuntu:${UBUNTU_VER:-22.04} AS base | |||
There was a problem hiding this comment.
One of the reasons we use variables like this is so that we only have to maintain them in one place. Setting the default value everywhere defeats the purpose of that.
Is there a compelling reason to set the default?
There was a problem hiding this comment.
Is there a compelling reason to set the default?
This is the kind of warning from docker.
https://docs.docker.com/reference/build-checks/invalid-default-arg-in-from/
1 warning found (use docker --debug to expand):
- InvalidDefaultArgInFrom: Default value for ARG ubuntu:${UBUNTU_VER} results in empty or invalid base image name (line 24)
But maybe that's not a good reason.
There was a problem hiding this comment.
The risk from that warning is understood and pretty much nil, so I'm thinking it's acceptable to not fix it.
There was a problem hiding this comment.
ok. then do we close pr or keep some of the changes?
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
pfi79
force-pushed
the
update-dockerfile
branch
from
a11dd91
to
e3eb778
Compare
denyeart
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.