Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to avoid timing windows in WebSocket eventstream resulting in blocked streams in edge case reconnect scenario #152

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Updates to avoid timing windows in WebSocket eventstream resulting in blocked streams in edge case reconnect scenario #152

merged 3 commits into from
Sep 28, 2021

Commits on Sep 28, 2021

  1. Use non-blocking push of bool rather than close channel, and extra lo… 

    …gging

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
    @peterbroadhurst
    peterbroadhurst committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    d52a867 View commit details
    Browse the repository at this point in the history

  2. Remove close channel completed, and drain errors before sending 

    Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
    @peterbroadhurst
    peterbroadhurst committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    95ad9eb View commit details
    Browse the repository at this point in the history

  3. Missed coverage 

    Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
    @peterbroadhurst
    peterbroadhurst committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9aeade1 View commit details
    Browse the repository at this point in the history