Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark filter stale for Besu nodes #238

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Nov 7, 2023

Not all Ethereum nodes return exactly the same error message when a filter does not exist. This caused ETHConnect to not be able to recreate a filter automatically in some cases, for example if a Besu node was restarted. This would result in log messages like:

[2023-10-19T06:50:07.739Z] ERROR es-1fb7a291-487f-404b-44ab-0a36a0da4dae: subscription error: Filter not found

This PR fixes this issue to make ETHConnect a bit more flexible to be able to recreate the filter automatically in this case.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #238 (828d35a) into main (111eb89) will decrease coverage by 0.04%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head 828d35a differs from pull request most recent head 64c391b. Consider uploading reports for the commit 64c391b to get more accurate results

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   97.26%   97.22%   -0.04%     
==========================================
  Files          59       59              
  Lines        7521     7524       +3     
==========================================
  Hits         7315     7315              
- Misses        163      165       +2     
- Partials       43       44       +1     

see 2 files with indirect coverage changes

@nguyer nguyer merged commit cfc1538 into hyperledger:main Nov 7, 2023
2 checks passed
@nguyer nguyer deleted the fix-filter-not-found branch November 7, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants