Fix docker build and add to PR checks #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
reviewed
Mar 1, 2024
build_log.txt
Outdated
There was a problem hiding this comment.
Did you mean to ignore this?
There was a problem hiding this comment.
Yep. Force pushed to make it disappear. Thanks.
awrichar
approved these changes
Mar 1, 2024
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix a couple issue with the Dockerfile. They also add the docker build to the PR checks so we don't end up merging something that means we can't build images anymore.