Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow formatting of string errors separately from matching #85

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Allow formatting of string errors separately from matching #85

merged 4 commits into from
Nov 1, 2024

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Oct 24, 2024 •
edited
Loading

Couple of API enhancements:

  • Ability to format errors separately to detecting them, including fixing the formatting of addresses in those strings
  • Ability to round-trip the transaction data for EIP-1559, without signing

@peterbroadhurst
Allow formatting of string errors separately from matching
eafd71c 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst
Format bytes/addresses in errors with 0x
13d52d4 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst
Correct serializer for bytes
6789f16 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst
Allow round-tripping of unsigned EIP-1559 signature payloads
656dd98 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst mentioned this pull request Oct 28, 2024
Merged
25 tasks
@awrichar awrichar merged commit b366550 into main Nov 1, 2024
3 checks passed
@awrichar awrichar deleted the err-flexibility branch November 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awrichar awrichar awrichar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbroadhurst @awrichar