Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions #5

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update Github Actions #5

merged 2 commits into from
Sep 20, 2023

Conversation

denisandreenko
Copy link
Member

No description provided.

Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions on the repo settings, but otherwise looks fine. If there are good reasons for the repo settings, feel free to merge as-is.

default_branch: main
has_downloads: false
has_downloads: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What downloads will this repo have?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this option is about releases tar files,
which will appear soon when the service release.

has_issues: true
has_projects: true
has_wiki: false
has_wiki: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have content for a Tezosconnect specifici wiki? Typically we've been steering away from repo-specific Wikis and putting everything in the main FireFly docs site.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found this option for EVM Connect and thought that it's about the main FireFly docs site.
But now I realised that it's about specific project wiki.
Thanks for that. (The option needs to be updated for EVM Connector as well)

Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@bb42eb7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   31.13%           
=======================================
  Files           ?       22           
  Lines           ?      851           
  Branches        ?        0           
=======================================
  Hits            ?      265           
  Misses          ?      581           
  Partials        ?        5           

@denisandreenko denisandreenko merged commit 4ab7adb into hyperledger:main Sep 20, 2023
2 checks passed
@denisandreenko denisandreenko deleted the feature/ci_cd branch September 20, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants