update connector to support custom URI's #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorsher
requested review from
awrichar,
peterbroadhurst,
nguyer and
dechdev
as code owners
shorsher
force-pushed
the
app-uri-changes
branch
2 times, most recently
from
61d61fb
to
4d4bf99
Compare
`mint` and `createpool` api's now accept a `uri` parameter Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
force-pushed
the
app-uri-changes
branch
from
4d4bf99
to
a8bf44f
Compare
awrichar
reviewed
Jun 27, 2022
awrichar
reviewed
Jun 27, 2022
awrichar
reviewed
Jun 27, 2022
awrichar
reviewed
Jun 27, 2022
- only expose `uri` param on `TokenMint` - `iid` logic cleanup - better naming for cache of uri support Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
awrichar
reviewed
Jun 29, 2022
awrichar
reviewed
Jun 29, 2022
awrichar
reviewed
Jun 29, 2022
awrichar
reviewed
Jun 29, 2022
awrichar
reviewed
Jun 29, 2022
- add short-circuit preventing unnecessary transactions Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a chain with #60