Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport of custom uri suppport #62

Closed
wants to merge 5 commits into from
Closed

backport of custom uri suppport #62

wants to merge 5 commits into from

Commits on Jun 24, 2022

  1. Support custom URI's for ERC721WithData 

    The ERC721WithData contract now supports custom token URI's on mint.

 - constructor now takes an optional baseURI string
 - new MintWithURI method that sets the URI for the provided token id

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
    @shorsher
    shorsher committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    f4201db View commit details
    Browse the repository at this point in the history

  2. add onlyOwner protection, updated comments 

    Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
    @shorsher
    shorsher committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9f5dd5a View commit details
    Browse the repository at this point in the history

  3. update ERC721WithData and TokenFactory interfaces 

     - Added new TokenFactory interface for ERC165 support
 - Updated ERC721WithData interace to include MintWithURI

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
    @shorsher
    shorsher committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ffdbe85 View commit details
    Browse the repository at this point in the history

  4. connector changes to support custom URI's 

    `mint` and `createpool` api's now accept a `uri` parameter

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
    @shorsher
    shorsher committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1b531d0 View commit details
    Browse the repository at this point in the history

  5. update e2e tests 

    Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
    @shorsher
    shorsher committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ef9c7b3 View commit details
    Browse the repository at this point in the history