-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mockery version #119
Conversation
f6e181e
to
aa04562
Compare
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/hyperledger/firefly-transaction-manager | |||
|
|||
go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually do golang version update across Firefly repos and don't normally pin to a specific patch version. e.g., it should be go 1.22
in this example
@EnriqueL8 is there a plan for the minor version 22 yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't set a plan yet for it, will keep that in mind - @alex-semenyuk is it strictly needed for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-semenyuk ^^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EnriqueL8 sorry for delay, yes, we can move without version update, so updated PR
Btw noticed that there is intermittently failed test #127
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
e2c0ca4
to
48085be
Compare
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
48085be
to
573f26d
Compare
Fix issue on
make mocks
Explicit define version instead of latest for mockery as recommended https://vektra.github.io/mockery/latest/installation/