Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mockery version #119

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented May 19, 2024

Fix issue on make mocks

internal error: package "context" without types was imported from "github.com/hyperledger/firefly-transaction-manager/pkg/fftm"
make: *** [mocks--Manager] Error 1

Explicit define version instead of latest for mockery as recommended https://vektra.github.io/mockery/latest/installation/

@alex-semenyuk alex-semenyuk requested a review from a team as a code owner May 19, 2024 10:29
@alex-semenyuk alex-semenyuk marked this pull request as draft May 19, 2024 10:31
@alex-semenyuk alex-semenyuk force-pushed the update_mockery branch 3 times, most recently from f6e181e to aa04562 Compare May 20, 2024 14:18
@alex-semenyuk alex-semenyuk marked this pull request as ready for review May 20, 2024 14:24
go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/hyperledger/firefly-transaction-manager

go 1.21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do golang version update across Firefly repos and don't normally pin to a specific patch version. e.g., it should be go 1.22 in this example

@EnriqueL8 is there a plan for the minor version 22 yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't set a plan yet for it, will keep that in mind - @alex-semenyuk is it strictly needed for this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnriqueL8 sorry for delay, yes, we can move without version update, so updated PR
Btw noticed that there is intermittently failed test #127

Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
@alex-semenyuk alex-semenyuk force-pushed the update_mockery branch 4 times, most recently from e2c0ca4 to 48085be Compare July 20, 2024 20:55
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
@Chengxuan Chengxuan merged commit 83ae49a into hyperledger:main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants