Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates integrating with ethconnect #3

Merged
merged 17 commits into from
Apr 20, 2022
Merged

Updates integrating with ethconnect #3

merged 17 commits into from
Apr 20, 2022

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Apr 20, 2022

These are a set of additional changes on top of #2 as I work through additional scenarios.

Corresponding changes in EthConnect are in PR hyperledger/firefly-ethconnect#213

@peterbroadhurst peterbroadhurst changed the title Updates Updates integrating with ethconnect Apr 20, 2022
@peterbroadhurst peterbroadhurst marked this pull request as ready for review April 20, 2022 12:28
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #3 (8c3f9e0) into main (4b8046d) will decrease coverage by 2.02%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##              main       #3      +/-   ##
===========================================
- Coverage   100.00%   97.97%   -2.03%     
===========================================
  Files           14       14              
  Lines          910      938      +28     
===========================================
+ Hits           910      919       +9     
- Misses           0       17      +17     
- Partials         0        2       +2     
Impacted Files Coverage Δ
internal/confirmations/confirmations.go 100.00% <ø> (ø)
internal/manager/manager.go 90.15% <37.93%> (-9.85%) ⬇️
cmd/fftm.go 100.00% <100.00%> (ø)
internal/manager/ffcore.go 100.00% <100.00%> (ø)
internal/manager/receipts.go 100.00% <100.00%> (ø)
internal/manager/routes.go 100.00% <100.00%> (ø)
internal/policyengines/simple/config.go 100.00% <100.00%> (ø)
...ernal/policyengines/simple/simple_policy_engine.go 100.00% <100.00%> (ø)
internal/tmconfig/tmconfig.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8046d...8c3f9e0. Read the comment docs.

@peterbroadhurst peterbroadhurst merged commit 281f7a4 into main Apr 20, 2022
@peterbroadhurst peterbroadhurst deleted the updates branch April 20, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants