-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add new tests and refactoring #1442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Test Results20 files ±0 20 suites ±0 3s ⏱️ ±0s Results for commit 6c69755. ± Comparison against base commit 7839b95. This pull request removes 10 and adds 12 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
amagyar-iohk
force-pushed
the
tests/crypto-merge
branch
from
November 18, 2024 12:57
1bd032b
to
bae9ccd
Compare
yshyn-iohk
reviewed
Nov 19, 2024
yshyn-iohk
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done, @amagyar-iohk!
amagyar-iohk
force-pushed
the
tests/crypto-merge
branch
from
November 19, 2024 19:11
9570dca
to
f3f1c9a
Compare
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> test: finalized tests and refactoring Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Revert "fix: use Kafka 'earliest' offset strategy to avoid missing messages" This reverts commit 241abe8. Revert "chore: reduce Kafka clients lib log verbosity" This reverts commit 8935889. style: apply linters automatic fixes (#1449) Signed-off-by: Hyperledger Bot <hyperledger-bot@hyperledger.org> Co-authored-by: Hyperledger Bot <hyperledger-bot@hyperledger.org> test: removes unused code Signed-off-by: Allain Magyar <allain.magyar@iohk.io> style: apply linters automatic fixes (#1456) Signed-off-by: Hyperledger Bot <hyperledger-bot@hyperledger.org> Co-authored-by: Hyperledger Bot <hyperledger-bot@hyperledger.org>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
amagyar-iohk
force-pushed
the
tests/crypto-merge
branch
from
November 20, 2024 18:22
e2a1803
to
6fe6136
Compare
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds more tests and refactoring
Checklist: