Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: share Kafka producers among threads #1460

Merged
merged 7 commits into from
Nov 21, 2024
Merged

feat: share Kafka producers among threads #1460

merged 7 commits into from
Nov 21, 2024

Conversation

bvoiturier
Copy link
Contributor

No description provided.

@bvoiturier
feat: allow ZIO scope to be passed to ZKafkaConsumer to better contro…
0221ffc 
…l lifecycle

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
test: fix unit tests
4ff4ea5 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
chore: require ZIO scope when making a new ZKafkaConsumer
597cf92 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
chore: downsize the Kafka consumers and retry topics configuration
eff93ab 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier bvoiturier requested a review from a team as a code owner November 20, 2024 12:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Unit Test Results

104 files  ±0  104 suites  ±0   20m 38s ⏱️ -16s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ec799e4. ± Comparison against base commit 8781d3d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ -1s
56 tests ±0  56 ✅ ±0  0 💤 ±0  0 ❌ ±0 
98 runs  ±0  98 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec799e4. ± Comparison against base commit 8781d3d.

♻️ This comment has been updated with latest results.

@bvoiturier
chore: run scalafmt
da843db 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
Merge branch 'main' into feat/share-kafka-producers
c6436a8
@coveralls
Copy link

coveralls commented Nov 20, 2024 •
edited
Loading

Coverage Status

coverage: 48.859% (+0.005%) from 48.854%
when pulling ec799e4 on feat/share-kafka-producers
into 8781d3d on main.

@bvoiturier bvoiturier enabled auto-merge (squash) November 20, 2024 13:21
@bvoiturier bvoiturier merged commit 5ece0dd into main Nov 21, 2024
14 checks passed
@bvoiturier bvoiturier deleted the feat/share-kafka-producers branch November 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
cloud-agent connect infra pollux shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvoiturier @coveralls @yshyn-iohk