Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the jwt to have shortform of prism did #1461

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Nov 20, 2024

Description:

Update the JWT to use the short-form DID in the iss field instead of the long-form DID.
#1451

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
Copy link
Contributor

Reminder to use breaking change for this case as it will break implementations in the SDK's if people don't have a custom resolver

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ -1s
56 tests ±0  56 ✅ ±0  0 💤 ±0  0 ❌ ±0 
98 runs  ±0  98 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dc275f0. ± Comparison against base commit 8781d3d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Test Results

104 files  ±0  104 suites  ±0   19m 23s ⏱️ - 1m 31s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit dc275f0. ± Comparison against base commit 8781d3d.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Nov 20, 2024

Coverage Status

coverage: 48.907% (+0.05%) from 48.854%
when pulling dc275f0 on fix/issuer-shortform-did
into 8781d3d on main.

Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants