Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SD-JWT verification #208

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: SD-JWT verification #208

wants to merge 24 commits into from

Conversation

cristianIOHK
Copy link
Contributor

@cristianIOHK cristianIOHK commented Sep 25, 2024

Description:

This PR brings SD-JWT verification across SDKs.

Breaking change: Deprecated createJWTPresentationSubmission and createAnoncredsPresentationSubmission

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Copy link

github-actions bot commented Sep 25, 2024

Unit Test Results

159 tests  +7   157 ✅ +8   7s ⏱️ ±0s
 28 suites +2     2 💤  - 1 
 28 files   +2     0 ❌ ±0 

Results for commit ab8ec6a. ± Comparison against base commit fce300e.

This pull request removes 2 and adds 9 tests. Note that renamed tests count towards both.
org.hyperledger.identus.walletsdk.pollux.PolluxImplTest ‑ testCreatePresentationSubmission_whenCredentialNotJWT_thenExceptionThrown
org.hyperledger.identus.walletsdk.pollux.PolluxImplTest ‑ testCreatePresentationSubmission_whenPrivateKeyNotSecp256k1_thenExceptionThrown
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ test handlePresentationDefinitionRequest for SD-JWT
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ test handlePresentationDefinitionRequest for SD-JWT with no options, fails
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ test initiatePresentationRequest SD-JWT
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ testCreateNewPrismDID_whenVcSdJwt_then
org.hyperledger.identus.walletsdk.pollux.DescriptorPathTest ‑ testGetValue_whenDollarSign_thenValueFound
org.hyperledger.identus.walletsdk.pollux.DescriptorPathTest ‑ testGetValue_whenNotDollarSign_thenValueFound
org.hyperledger.identus.walletsdk.pollux.PolluxImplTest ‑ Test SD-JWT createPresentationDefinitionRequest
org.hyperledger.identus.walletsdk.pollux.PolluxImplTest ‑ test verifyPresentationSubmission SD-JWT
org.hyperledger.identus.walletsdk.pollux.models.SDJWTCredentialTest ‑ test credential presentation

♻️ This comment has been updated with latest results.

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK cristianIOHK marked this pull request as ready for review September 25, 2024 19:43
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@elribonazo elribonazo linked an issue Oct 30, 2024 that may be closed by this pull request
…llo instead

fix: code improvements to allow passing additional authentication keys to Castor.createPrismDID
@elribonazo elribonazo requested a review from a team as a code owner November 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Verification in SDK - SD-JWT-VC
2 participants