Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update connectionless documentation and examples #305

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chereseeriepa
Copy link
Contributor

@chereseeriepa chereseeriepa commented Oct 15, 2024

Description:

This PR updates the documentation and examples for the connectionless flow. This includes diagrams outlining the steps involved with connectionless issuance and verification of verifiable credentials.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
Copy link
Contributor

@chereseeriepa is this ready for review, if so, please change the status to open, then we'll start review process :)

@chereseeriepa chereseeriepa marked this pull request as ready for review October 29, 2024 01:17
@chereseeriepa chereseeriepa requested a review from a team as a code owner October 29, 2024 01:17
@chereseeriepa chereseeriepa marked this pull request as draft October 29, 2024 01:21
@elribonazo elribonazo marked this pull request as ready for review November 14, 2024 13:20
@elribonazo
Copy link
Contributor

@chereseeriepa We've recently used those in the SDJWT workshop we ran and i see all the doc improvements are correct, gonna check couple additional things.

What I'd please ask you is try to and configure DCO on your machine and fix the commits. If you click here also documented in our Contribution Guidelines

It will show you what commands to run to fix it, thank you!

docs/examples/ConnectionlessOffer.md Outdated Show resolved Hide resolved
docs/examples/ConnectionlessOffer.md Outdated Show resolved Hide resolved
@elribonazo
Copy link
Contributor

For the rest, the PR looks awesome and is very much appreciated @chereseeriepa !

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11566145795

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 72.788%

Files with Coverage Reduction New Missed Lines %
src/domain/utils/DER.ts 3 35.14%
Totals Coverage Status
Change from base Build 11556271983: -0.06%
Covered Lines: 3434
Relevant Lines: 4514

💛 - Coveralls

@chereseeriepa chereseeriepa marked this pull request as draft November 18, 2024 01:03
Signed-off-by: chereseeriepa <cherese.eriepa@outlook.com>
Signed-off-by: chereseeriepa <cherese.eriepa@outlook.com>
Signed-off-by: chereseeriepa <cherese.eriepa@outlook.com>
@chereseeriepa chereseeriepa marked this pull request as ready for review November 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants