Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing Startable and propagating stop() #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

curtis-h
Copy link
Contributor

Description:

Issue: #225

Agent.stop() now chains into Pluto.stop() which chains to Store.stop().

  • Created Startable namespace to define and share implementation.
  • added optional stop fn to Pluto interface,
    • avoided implementing Startable as it would be break the start() return type
  • Pollux implements Startable
  • Pluto
    • added Startable.State
    • improved start() fn
    • added stop() fn
  • Pluto/rxdb/Store added stop() fn
  • Agents
    • replaced duplicated AgentState with Startable.State
    • handled start and stop
  • added functional tests

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h requested a review from a team as a code owner October 22, 2024 12:14
Copy link

github-actions bot commented Oct 22, 2024

Lines Statements Branches Functions
Coverage: 76%
76.9% (3574/4647) 66.88% (1555/2325) 80.79% (875/1083)

@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 11609047595

Details

  • 68 of 73 (93.15%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 73.379%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/didcomm/Agent.ts 20 25 80.0%
Files with Coverage Reduction New Missed Lines %
src/domain/utils/DER.ts 3 35.14%
Totals Coverage Status
Change from base Build 11556271983: 0.5%
Covered Lines: 3470
Relevant Lines: 4523

💛 - Coveralls

@curtis-h curtis-h changed the title feat: implementing Startable and propogating stop() feat: implementing Startable and propagating stop() Oct 22, 2024
@elribonazo elribonazo linked an issue Oct 22, 2024 that may be closed by this pull request
Signed-off-by: Curtish <ch@curtish.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent.stop doesn't close store
3 participants