Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removing unused dependencies #316

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: removing unused dependencies #316

merged 1 commit into from
Nov 11, 2024

Conversation

curtis-h
Copy link
Contributor

Reviewing current dependencies

  • Moving to peerDependencies when we want some control over a sub-dependency.
  • Removing unused.
  • Removing React lint rules, we don't lint demos.
  • Updated anoncreds-browser reference.

Tested with

  • npm run build
  • npm run test
  • npm run coverage
  • npm run docs
  • npm run lint
  • demos/next to mediation

@curtis-h curtis-h self-assigned this Oct 31, 2024
@curtis-h curtis-h requested a review from a team as a code owner October 31, 2024 13:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Lines Statements Branches Functions
Coverage: 75%
 76.08% (3633/4775) 66.49% (1665/2504) 80.29% (864/1076)

@coveralls
Copy link

coveralls commented Oct 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11779921721

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.553%
Totals Coverage Status
Change from base Build 11779355500: 0.0%
Covered Lines: 3524
Relevant Lines: 4648
💛 - Coveralls

@curtis-h
chore: removing unused dependencies
edd2a71 
Signed-off-by: Curtish <ch@curtish.me>
@curtis-h curtis-h merged commit 695071f into main Nov 11, 2024
6 checks passed
@curtis-h curtis-h deleted the chore/dependency-tidy branch November 11, 2024 14:22
elribonazo pushed a commit that referenced this pull request Nov 12, 2024
@curtis-h @elribonazo
chore: removing unused dependencies (#316)
ed17ad6 
Signed-off-by: Curtish <ch@curtish.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

Assignees

@curtis-h curtis-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtis-h @coveralls @elribonazo