Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commonJs default export #339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: commonJs default export #339

wants to merge 1 commit into from

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Nov 14, 2024

Description:

Our exported index.cjs was exporting a flattened object, but the Types show a default and commonJs targeted builds with TS would fail, expecting a default property which didn't exist.

Adds a default property to the export if one doesn't already exist.

Adding integration tests for TS builds to cjs and esm, and making all node integration tests use the same tests.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Nov 14, 2024
@curtis-h curtis-h requested a review from a team as a code owner November 14, 2024 15:21
Signed-off-by: Curtish <ch@curtish.me>
Copy link

Lines Statements Branches Functions
Coverage: 75%
76.14% (3636/4775) 66.53% (1666/2504) 80.29% (864/1076)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11840451295

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 72.613%

Totals Coverage Status
Change from base Build 11819333201: 0.06%
Covered Lines: 3528
Relevant Lines: 4649

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants