Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of helm chart with prmetheus and alertmanager as optionals #79

Open
wants to merge 1 commit into
base: k8s-influxdb
Choose a base branch
from

Conversation

GuillaumeBourque-QC
Copy link
Contributor

This code will allow to deploy the indy-node-monitor solution in OpenShift or K8s.

All the dashboards and alerts are relying on influxdb only. So even if you enable prometheus it wont be used by the dashbaord but will be available.

It's a functionnal first draft, since I'm not a k8s expert I may have miss some best practice.

All feedback will be appreciated.

Signed-off-by: GuillaumeBourque-QC <guillaume.bourque-ext@mcn.gouv.qc.ca>
@WadeBarnes WadeBarnes self-requested a review October 18, 2024 15:43
@WadeBarnes
Copy link
Member

WadeBarnes commented Oct 18, 2024

Took a very quick cursory pass over the changes.

You shouldn't need to define and manage any routes, such as charts/templates/grafana/route.yml, you should just be able to define ingresses. OpenShift will auto-generate and manage any necessary routes when you provision a k8s ingress.

When properly setup OpenShift will manage the route and it's properties for any k8s ingress you define, including management of any TLS certificates defined on the ingress. Changes to the tls secret for the ingress will be reflected on the route.

I believe this is accomplished by defining ingressClassName in the ingress and setting it to default, setting it to "". OpenShift should then translate that to openshift-default and auto-generate a managed route. The managed route will contain an ownerReferences section to the associated ingress.

@GuillaumeBourque-QC
Copy link
Contributor Author

Thanks, I don't have much view on how OpenShift is configured (no rights at all) and not much deep knowledge, but when I did try the ingress way it never worked for me and I was suggested to use a route which was working for other projects.

That's why I made this choice as optional, you can specify one or the other depending on you needs in the values.yaml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants