fixing broken link in generated docs #1610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in https://hyperledger-indy.readthedocs.io/projects/plenum/en/latest/main.html the `.md` extension gets lost in doc generation
Echsecutor
requested review from
lampkin-diet,
ashcherbakov,
skhoroshavin and
Toktar
as code owners
|
Can one of the admins verify this patch? |
|
@Echsecutor Could you provide a brief update on this PR? With recent branch changes and the current development process on Indy Node/Plenum, we are wondering if these changes are still viable. If so, please close this PR and retarget it to We will discuss and determine which PRs should be merged or closed at the next Indy Contributors Working Group meeting on May 9, 2023. |
|
Retargeted to the |
WadeBarnes
requested changes
May 9, 2023
| @@ -1,6 +1,6 @@ | |||
| # Create a Network and Start Nodes | |||
|
|
|||
| Please be aware that recommended way of starting a pool is to [use Docker](https://github.com/hyperledger/indy-node/blob/master/environment/docker/pool/README.md). | |||
| Please be aware that recommended way of starting a pool is to [use Docker](https://github.com/hyperledger/indy-node/tree/master/environment/docker/pool). | |||
There was a problem hiding this comment.
Suggested change
| Please be aware that recommended way of starting a pool is to [use Docker](https://github.com/hyperledger/indy-node/tree/master/environment/docker/pool). | |
| Please be aware that recommended way of starting a pool is to [use Docker](https://github.com/hyperledger/indy-node/tree/main/environment/docker/pool). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in https://hyperledger-indy.readthedocs.io/projects/plenum/en/latest/main.html the
.mdextension gets lost in doc generation