-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Indy-Besu PoC #1821
Add Indy-Besu PoC #1821
Conversation
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: renata.toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: Artemkaaas <artem.ivanov@dsr-corporation.com>
Signed-off-by: renata.toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
…id:ethr` Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
Signed-off-by: aziz.karabashov <aziz.karabashov@dsr-corporation.com>
…lver Make CL AnonCreds to work with did:indy and did:ethr
@Toktar @Artemkaaas Apologies for taking this long time getting back to this. I have partially completed another pass over the comments and feedback, left some replies. I'll be continuing tomorrow. Great discussion and please to see that you have already addressed some of the concerns 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PoC proved a possibility of using Besu for permissioned Indy ledger.
No concerns to push into experimental branch to not lose the work.
There is ongoing discussion if the PoC should stay in the branch or be moved into a separate rep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from the perspective of:
- proving capability to store anoncreds on chain
- proving capability to permission validators for private deployments
- proving capability to permission network writes for private deployments
- proving credential issaunce and verification e2e against the novel anoncreds method.
That being said, learnings should be taken from this POC and IMO further development should be done. I have expressed my position (and raised some questions) quite extensively here #1826 (comment)
My proposal for the next steps is:
- Use https://github.com/gmulhearn/anoncreds-on-ethereum as basis did&anoncreds method
- DID method: well known
did:ethr
- Anoncreds method: new, support rev registries, built on top of
did:ethr
- Simple contracts
- DID method: well known
- Use this POC as basis for network permissioning of
- validators
- write transactions
- Lastly decide on the way of organizing, I am in favor of new repo.
Apart from proving various aspect of permissioned anoncreds infra on Besu, I find this PR also valuable from perspective of 2nd order effects in kicked off - it triggered fusing mental energy into the researching alternative approach (the repo linked above). I think we are in good position where we can compare 2 streams of work and cherry pick the desirable attributes/components of both.
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Update Indy Besu README with some warns
65645ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving, please note my comment #1821 (review)
@TelegramSam, @reflectivedevelopment, Could you also weigh in here. Do we have agreement on the conditions of acceptance as @Patrik-Stas has stated? Anything further to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving, see #1821 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as soon as @TelegramSam 's comments are included at the top of the new code README.md
I saw that, I'd just like the comments on the PR for completeness. |
This is not an official Indy Ledger code yet, but an experimental proof of concept (PoC). The goal is to prove a possibility to use Indy Besu as a foundation for Indy Ledger and show how it can be done.
The code and PoC may be moved to a separate Indy repository later for further development.
Plan for making this code official
Proposed by @TelegramSam in #1826
Goals and ideas
Permissioned
modulesgas
efficiency in favour general validation of the stored dataDesign documentation
See design document covering the main ledger aspects.
Contact list
Feel free to ask any questions here or in person. All team developers will be happy to answer.
Especially Renata
(GH: @Toktar ,
LinkedIn: https://www.linkedin.com/in/renata-toktar-999b7a15b/
discord: Renata Toktar#5546
email: renata.toktar@dsr-corporation.com)