Devcontainers #1580
Merged
Devcontainers #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
WadeBarnes
requested changes
Jan 24, 2022
|
I noted the following issues when running the tests in the virtual development environments: Like In the Gitpod there appears to be some timing issues with at least one test. This was not an issue with the Visual Studio Code Devcontainer. |
Signed-off-by: Lupusalix <github@lupusalix.de> Co-authored-by: Wade Barnes <wade@neoterictech.ca>
pSchlarb
force-pushed
the
vscode-devcontainer
branch
from
7637c6c
to
fb74223
Compare
WadeBarnes
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of devcontainers and their configuration files as requested in #1579.
Changes needed because of hyperledger-archives/indy-sdk#2473 have been marked with comments.