Build Span Attributes which may be missing from OTEL-provided Span #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradAtTraceable
requested review from
tyroneyu,
ryanericson and
shashank11p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Span that is create by the OTEL java agent may not have some of the attributes that are needed for properly evaluating the execution of a request. Specifically, the "http.url" attribute may be missing. This PR produces a Map of those Span attributes that are required, but may not exist, in the OTEL-provided Span. The contents of this possibly-missing attribute Map may then be used during the evaluation of the request execution.
Note that the possibly-missing attributes are not merged into the Span with this PR. Instead, they are provided as a separate (optional) argument to the Filter.evaluateRequestHeaders() and .evaluateRequestBody() methods.