add filedescriptor class #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Nov 20, 2024
vaxerski
reviewed
Nov 21, 2024
added a test case, think im testing most of the things. used shm_open as an example |
|
last thing, I'd move that under OS rather than utils. |
makes you able to RAII the filedescriptor making it somewhat easier to not leak.
moved |
vaxerski
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would be neat to slowly consume up all the manual handling of fd closing and using something like this, but needs some sharper eyes on the various constructors and operators. got to say i lack there
based on kwin's idea of FD handling.