-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created schema search feature #40
Conversation
@@ -0,0 +1,68 @@ | |||
import React, { useState } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Great Progress! You're almost there Alex! 🦅 🦅 🦅 🦅 🦅 🦅 🦅
src/components/SchemaSearch.tsx
Outdated
{selectedSchema.map((str, index) => ( | ||
<p key={index}>{str}</p> | ||
))} | ||
<button className="cancel-button" onClick={clearSchema}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Use Button from mantine! Good to utilize mantine components as much as possible!
-
Instead of a Button + h1 to display selected schemas, look into the Notification component to see if you can utilize it to display selected files! You wouldn't need to worry about how it looks + the close function is already there. In the screenshot below, Notification component is used to display error messages -- just a suggestion however! :D
If u do implement Button, make sure the cancel button is visible AFTER a schema has been selected, and play around with how the selected schema display looks!
src/components/SchemaSearch.tsx
Outdated
</div> | ||
); | ||
}; | ||
//gotta figure out a way to hide the selected schema section until after a schema has been selected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at Line 82 and see how chosen files are handled here:
https://github.com/hytech-racing/query-frontend/blob/main/src/components/FileUpload.tsx
… to mantine button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! The comments were great btw! I just meant the first one where i wrote haha
in the future dont shy away from documenting ur code!
Created schema search function with section to display selected schema