Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created schema search feature #40

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Created schema search feature #40

merged 3 commits into from
Oct 25, 2024

Conversation

kaisernarkotic
Copy link
Contributor

Created schema search function with section to display selected schema

@@ -0,0 +1,68 @@
import React, { useState } from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Great Progress! You're almost there Alex! 🦅 🦅 🦅 🦅 🦅 🦅 🦅

{selectedSchema.map((str, index) => (
<p key={index}>{str}</p>
))}
<button className="cancel-button" onClick={clearSchema}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Use Button from mantine! Good to utilize mantine components as much as possible!

  2. Instead of a Button + h1 to display selected schemas, look into the Notification component to see if you can utilize it to display selected files! You wouldn't need to worry about how it looks + the close function is already there. In the screenshot below, Notification component is used to display error messages -- just a suggestion however! :D

If u do implement Button, make sure the cancel button is visible AFTER a schema has been selected, and play around with how the selected schema display looks!

Screenshot 2024-10-23 at 11 14 55 AM

</div>
);
};
//gotta figure out a way to hide the selected schema section until after a schema has been selected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at Line 82 and see how chosen files are handled here:
https://github.com/hytech-racing/query-frontend/blob/main/src/components/FileUpload.tsx

Copy link
Contributor

@aesteri aesteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! The comments were great btw! I just meant the first one where i wrote haha

in the future dont shy away from documenting ur code!

@kaisernarkotic kaisernarkotic merged commit 3ef4010 into main Oct 25, 2024
1 check passed
@kaisernarkotic kaisernarkotic deleted the SchemaSearch branch October 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants