Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a isString helper to avoid code duplication #1763

Merged
merged 2 commits into from
Jul 15, 2024
Merged

create a isString helper to avoid code duplication #1763

merged 2 commits into from
Jul 15, 2024

Conversation

VIKTORVAV99
Copy link
Contributor

Creates a simple isString helper function to avoid duplicated code when doing string checks.

It also adds the relevant tests for the new function.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 97.146% (+0.003%) from 97.143%
when pulling 8763e9f on VIKTORVAV99:isString_helper
into 46e8ea5 on i18next:master.

@adrai adrai merged commit a904e07 into i18next:master Jul 15, 2024
8 of 9 checks passed
@VIKTORVAV99 VIKTORVAV99 mentioned this pull request Oct 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VIKTORVAV99 @coveralls @adrai