Fix normalizeNode to keep text/inline nodes when removing blocks (#…

…5768) * fix: fix data loss in base `normalizeData` if no blocks allowed Use `unwrapNodes` instead of `removeNodes` to convert block to inline/text nodes. * changeset
ianstormtaylor · Nov 23, 2024 · 4bc552f · 4bc552f
1 parent 90fbcde
commit 4bc552f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/large-cars-itch.md b/.changeset/large-cars-itch.md
@@ -0,0 +1,5 @@
+---
+'slate': patch
+---
+
+Keep data in normalization when blocks are not allowed
diff --git a/packages/slate/src/core/normalize-node.ts b/packages/slate/src/core/normalize-node.ts
@@ -53,7 +53,11 @@ export const normalizeNode: WithEditorFirstArg<Editor['normalizeNode']> = (
     // other inline nodes, or parent blocks that only contain inlines and
     // text.
     if (isInlineOrText !== shouldHaveInlines) {
-      Transforms.removeNodes(editor, { at: path.concat(n), voids: true })
+      if (isInlineOrText) {
+        Transforms.removeNodes(editor, { at: path.concat(n), voids: true })
+      } else {
+        Transforms.unwrapNodes(editor, { at: path.concat(n), voids: true })
+      }
       n--
     } else if (Element.isElement(child)) {
       // Ensure that inline nodes are surrounded by text nodes.

diff --git a/packages/slate/test/normalization/block/remove-block.tsx b/packages/slate/test/normalization/block/remove-block.tsx
@@ -12,7 +12,7 @@ export const input = (
 export const output = (
   <editor>
     <block>
-      <text>one</text>
+      <text>onetwo</text>
     </block>
   </editor>
 )
diff --git a/packages/slate/test/normalization/inline/remove-block.tsx b/packages/slate/test/normalization/inline/remove-block.tsx
@@ -20,7 +20,7 @@ export const output = (
     <block>
       <text />
       <inline>
-        <text>twofour</text>
+        <text>onetwothreefour</text>
       </inline>
       <text />
     </block>