Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter IE vat validation #63

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Stricter IE vat validation #63

merged 1 commit into from
Nov 15, 2023

Conversation

VincentLanglet
Copy link
Contributor

Hi @dannyvankooten

Cf https://en.wikipedia.org/wiki/VAT_identification_number#VAT_numbers_by_country

The current check of VTA number for Ireland is too lax

'IE' + 7 digits and one letter, e.g. IE1234567T. Historically, married women used the ID of their husband appended with a 'W', e.g. IE1234567TW. The policy as of 2022 is that every individual has a unique ID.[13]
'IE' + 7 digits and two letters, e.g. IE1234567FA (since January 2013, see [1])
'IE'+one digit, one letter/"+"/"*", 5 digits and one letter (old style, currently being phased out, see [2])

I updated the regex and the tests

@dannyvankooten dannyvankooten merged commit 905499c into ibericode:master Nov 15, 2023
4 checks passed
@dannyvankooten
Copy link
Member

Nice, thank you @VincentLanglet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants