IBX-8626: Create action menu component foundations #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Aug 19, 2024
| @@ -1,5 +1,7 @@ | |||
| {%- import '@ibexadesign/ui/component/macros.html.twig' as html -%} | |||
|
|
|||
| {%- set group_template_path = group_template_path|default('@ibexadesign/ui/component/multilevel_popup_menu/multilevel_popup_menu_group.html.twig') -%} | |||
|
|
|||
| @@ -1,5 +1,7 @@ | |||
| {%- import '@ibexadesign/ui/component/macros.html.twig' as html -%} | |||
|
|
|||
| {%- set group_template_path = group_template_path|default('@ibexadesign/ui/component/multilevel_popup_menu/multilevel_popup_menu_group.html.twig') -%} | |||
|
|
|||
| {%- set is_template = is_template|default(false) -%} | |||
|
|
|||
| @@ -1,5 +1,7 @@ | |||
| {%- import '@ibexadesign/ui/component/macros.html.twig' as html -%} | |||
|
|
|||
| {%- set item_template_path = item_template_path|default('@ibexadesign/ui/component/multilevel_popup_menu/multilevel_popup_menu_item.html.twig') -%} | |||
|
|
|||
| @@ -1,5 +1,7 @@ | |||
| {%- import '@ibexadesign/ui/component/macros.html.twig' as html -%} | |||
|
|
|||
| {%- set item_template_path = item_template_path|default('@ibexadesign/ui/component/multilevel_popup_menu/multilevel_popup_menu_item.html.twig') -%} | |||
|
|
|||
| {%- set is_template = is_template|default(false) -%} | |||
|
|
|||
| @@ -1,5 +1,7 @@ | |||
| {%- import '@ibexadesign/ui/component/macros.html.twig' as html -%} | |||
|
|
|||
| {%- set branch_template_path = branch_template_path|default('@ibexadesign/ui/component/multilevel_popup_menu/multilevel_popup_menu_branch.html.twig') -%} | |||
|
|
|||
| @@ -1,5 +1,7 @@ | |||
| {%- import '@ibexadesign/ui/component/macros.html.twig' as html -%} | |||
|
|
|||
| {%- set branch_template_path = branch_template_path|default('@ibexadesign/ui/component/multilevel_popup_menu/multilevel_popup_menu_branch.html.twig') -%} | |||
|
|
|||
| {%- set is_template = is_template|default(false) -%} | |||
|
|
|||
There was a problem hiding this comment.
For me these spaces are ok :)
dew326
approved these changes
Aug 20, 2024
tischsoic
requested changes
Sep 10, 2024
Comment on lines
+206
to
+216
| const searchInput = branchElement.querySelector('.ibexa-multilevel-popup-menu__search-input'); | ||
|
|
||
| if (searchInput?.value !== '') { | ||
| searchInput.value = ''; | ||
| searchInput.dispatchEvent(new Event('input')); | ||
| } |
There was a problem hiding this comment.
I think this has to be placed inside toggleBranch otherwise, it will be inconsistent.
dew326
approved these changes
Sep 12, 2024
lucasOsti
approved these changes
Sep 13, 2024
tischsoic
approved these changes
Sep 13, 2024
tomaszszopinski
approved these changes
Sep 17, 2024
GrabowskiM
force-pushed
the
ai-front
branch
from
fb7e91d
to
c05d087
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: