IBX-8800: Fixed subitems filtering #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
requested changes
Aug 21, 2024
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Outdated
Show resolved
Hide resolved
konradoboza
reviewed
Aug 22, 2024
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Aug 22, 2024
ciastektk
force-pushed
the
ibx-8800-fixed-subitems-filtering
branch
2 times, most recently
from
ff28fa7
to
e5d1789
Compare
Steveb-p
reviewed
Aug 26, 2024
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Outdated
Show resolved
Hide resolved
ciastektk
force-pushed
the
ibx-8800-fixed-subitems-filtering
branch
from
e5d1789
to
e143783
Compare
Steveb-p
approved these changes
Aug 26, 2024
alongosz
approved these changes
Aug 26, 2024
konradoboza
approved these changes
Aug 26, 2024
ViniTou
approved these changes
Aug 26, 2024
ciastektk
force-pushed
the
ibx-8800-fixed-subitems-filtering
branch
from
e143783
to
0e449f9
Compare
This was referenced Aug 29, 2024
ciastektk
force-pushed
the
ibx-8800-fixed-subitems-filtering
branch
from
0e449f9
to
f95a231
Compare
ciastektk
force-pushed
the
ibx-8800-fixed-subitems-filtering
branch
from
f95a231
to
bc132ba
Compare
|
bogusez
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently
LogicalAndcriterion is always added to query viaContentTreeChildrenQueryArgumentResolverandContentTreeController::loadChildrenAction. When using solr or elasticserach engine and filter parameter is not passed to request, exception aboutInvalid aggregation in LogicalAnd criterionis throw.This PR changes type hint of
$filterparameter fromCriterionto?CriterioninContentTreeController::loadChildrenAction. This allows to yield null value inContentTreeChildrenQueryArgumentResolver::resolvewhen processed array of filter criteria is empty.For QA:
Documentation: