Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPStan] Fixed errors after PHPStan update #1339

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[PHPStan] Fixed errors after PHPStan update #1339

merged 1 commit into from
Sep 4, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Sep 4, 2024 •
edited
Loading

@ciastektk ciastektk requested a review from a team September 4, 2024 10:51
Steveb-p
Steveb-p requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the error message that PHPStan gives?

src/lib/Form/EventListener/BuildPathFromRootListener.php Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ciastektk ciastektk requested a review from a team September 4, 2024 12:34
@ciastektk ciastektk merged commit 95a99fb into 4.6 Sep 4, 2024
29 checks passed
@ciastektk ciastektk deleted the fixed-phpstan branch September 4, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciastektk @adamwojs @Steveb-p @mikadamczyk @Nattfarinn @ViniTou