Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React lifecycle warning #711

Open
mathisonian opened this issue Mar 10, 2021 · 0 comments
Open

React lifecycle warning #711

mathisonian opened this issue Mar 10, 2021 · 0 comments
Labels
Components Good First PR help wanted Rough Edges Runtime

Comments

@mathisonian
Copy link
Member

Describe the bug
Some components depend on React lifecycle methods that are being deprecated, see this warning:

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.\n

To Reproduce
Create the default idyll article and look at terminal and JS console.

Expected behavior
There are no warnings from React. I believe the idyll-document component relies on this method, as well as several components in idyll-components, including at least table, maybe others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Components Good First PR help wanted Rough Edges Runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathisonian