Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring react table to last v6 version to clear lifecycle warnings. #722

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

NickFoden
Copy link
Contributor

@NickFoden NickFoden commented Mar 31, 2021

🚧 wip 🚧

Currently looking for good table examples to test with, cleaning up the componentWillMount warnings, the react table package is also throwing these warnings - #711

But wanted to open a draft PR to see if any thoughts on how Idyll is using react-table and also if/when react hooks integration on horizon.

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  • Other information:

… api changes for v7 of react-table and needs hooks api i believe
@mathisonian
Copy link
Member

Nice! Thanks for taking this on @NickFoden.

Some good table examples are here: https://idyll.pub/post/derived-table-b00359641a4490037dc3dce7/ and here: https://idyll.pub/post/dynamic-data-e13c64946ffab6b5110af990/ (source)

With the work in #716 I think we should be good to update the React dependency to a more recent version that supports hooks.

@mathisonian mathisonian requested a review from megan-vo July 7, 2021 17:39
@megan-vo megan-vo mentioned this pull request Jul 27, 2021
2 tasks
@mathisonian mathisonian merged commit f4b105e into idyll-lang:master Jul 30, 2021
@NickFoden NickFoden deleted the update_react_table branch July 30, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants