Make save svg & save png method signatures consistent

igvteam · Aug 3, 2024 · 903de96 · 903de96
1 parent c556237
commit 903de96
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/dev/misc/svg.html b/dev/misc/svg.html
@@ -93,7 +93,7 @@
         const browser = await igv.createBrowser(document.getElementById('igv-app-container'), bedgraph_options)
 
         // $('#igv-draw-svg-button').on('click', () => browser.renderSVG($('#igv-svg-container')))
-        $('#igv-draw-svg-button').on('click', () => browser.saveSVGtoFile({ $container: $('#igv-svg-container') }))
+        $('#igv-draw-svg-button').on('click', () => browser.saveSVGtoFile(null, $('#igv-svg-container')[0]))
 
 
     })()

diff --git a/js/browser.js b/js/browser.js
@@ -447,23 +447,25 @@ class Browser {
         return context.getSerializedSvg(true)
     }
 
-    saveSVGtoFile(config) {
+    saveSVGtoFile(filename, container) {
 
-        let svg = this.toSVG()
+        let svgString = this.toSVG()
 
-        // For testing
-        if (config.$container) {
-            config.$container.empty()
-            config.$container.append(svg)
+        // Append svg t testing, not used in production
+        if (container) {
+            const svg = document.createElement("svg");
+            svg.innerHTML = svgString
+            container.append(svg)
+            container.appendChild(svg)
         }
 
-        const path = config.filename || 'igvjs.svg'
-        const data = URL.createObjectURL(new Blob([svg], {type: "application/octet-stream"}))
+        const path = filename || 'igvjs.svg'
+        const data = URL.createObjectURL(new Blob([svgString], {type: "application/octet-stream"}))
         FileUtils.download(path, data)
         URL.revokeObjectURL(data)  // Important to prevent memory leak
     }
 
-    savePNGtoFile({filename}) {
+    savePNGtoFile(filename) {
 
         const svgAsString = this.toSVG()