Remove unneeded await for call to synchronous browser.getUserDefinedR…

…OIs()
igvteam · Jul 24, 2024 · ebf8751 · ebf8751
1 parent ec7b3df
commit ebf8751
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/dev/roi/roi-api.html b/dev/roi/roi-api.html
@@ -83,7 +83,7 @@ <h3>User defined ROIs:</h3>
             const list = document.createElement("ul")
             div.appendChild(list)
 
-            const rois = await browser.getUserDefinedROIs()
+            const rois = browser.getUserDefinedROIs()
             if (rois) {
                 for (let r of rois) {
                     const li = document.createElement('li')

diff --git a/examples/roi/roi-api.html b/examples/roi/roi-api.html
@@ -28,7 +28,7 @@ <h3>User defined ROIs:</h3>
 
 <script type="module">
 
-    import igv from "../../dist/igv.esm.min.js"
+    import igv from "../../js/index.js"
 
     const browser_config =
         {
@@ -76,7 +76,7 @@ <h3>User defined ROIs:</h3>
             const list = document.createElement("ul")
             div.appendChild(list)
 
-            const rois = await browser.getUserDefinedROIs()
+            const rois = browser.getUserDefinedROIs()
             if (rois) {
                 for (let r of rois) {
                     const li = document.createElement('li')

diff --git a/js/browser.js b/js/browser.js
@@ -1162,7 +1162,7 @@ class Browser {
     }
 
     /**
-     * Public API function. Return a promise for the list of user-defined regions-of-interest
+     * Public API function. Return list of user-defined regions-of-interest
      */
     getUserDefinedROIs() {
 

diff --git a/js/feature/featureTrack.js b/js/feature/featureTrack.js
@@ -493,7 +493,7 @@ class FeatureTrack extends TrackBase {
 
         let color
 
-        if (this.browser.qtlSelections.hasPhenotype(f.name.toUpperCase())) {
+        if (f.name && this.browser.qtlSelections.hasPhenotype(f.name.toUpperCase())) {
             color = this.browser.qtlSelections.colorForGene(f.name.toUpperCase())
         } else if (this.altColor && "-" === feature.strand) {
             color = (typeof this.altColor === "function") ? this.altColor(feature) : this.altColor