fix: Freezing of Map values during finalization #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map keys are not enumerable properties of the Map object, so the propertyIsEnumerable check does not apply to them. This commit adds a condition to detect Map objects and uses Map.prototype.has to check for key existence. Fixes immerjs#1119.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findings
Map keys are not enumerable properties of the Map object, so the
propertyIsEnumerablecheck does not apply to them.This fails the check in
finalizePropertyofsrc/core/finalize.ts.Changes
Mapobjects and usesMap.prototype.hasto check for key existence.Fixes #1119