Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Album preview overview in menu #13981

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

TimVanOnckelen
Copy link

@TimVanOnckelen TimVanOnckelen commented Nov 7, 2024

This PR introduces a visual overview of the three latest albums in the main menu, similar to the App-Which-Must-Not-Be-Named. The addition provides quick album previews for users, enhancing navigation and user experience.

Changes Overview:

Album Menu Extension: Added a visual preview of three albums directly within the Album menu for quick access.
New Optional Parameter in API: Introduced top as an optional parameter in the /albums (getAllAlbums) route, allowing flexible limits on album retrieval.
Technical Details:

The top parameter supports optimized retrieval of album data by limiting results, enhancing efficiency for both UI rendering and API load.
The visual display integrates seamlessly with the existing menu styling, ensuring consistent user experience.

image

@bo0tzz
Copy link
Member

bo0tzz commented Nov 7, 2024

Implements part of #8743

@TimVanOnckelen TimVanOnckelen marked this pull request as ready for review November 7, 2024 12:55
@alextran1502
Copy link
Contributor

Hello, thanks for the PR. I am working on migrate the whole web codebase to the new rune syntax so new features on the web will have to wait 😅

@TimVanOnckelen
Copy link
Author

Hello, thanks for the PR. I am working on migrate the whole web codebase to the new rune syntax so new features on the web will have to wait 😅

Np, ofcourse! Where possible, i used your changes on the rune syntax from your pr #13883

@TimVanOnckelen TimVanOnckelen marked this pull request as draft November 10, 2024 08:07
@TimVanOnckelen
Copy link
Author

I will temporary set this PR back to draft until the svelte 5 migration is done.

@TimVanOnckelen TimVanOnckelen marked this pull request as ready for review November 15, 2024 17:01
@alextran1502
Copy link
Contributor

We don't need to modify the server query. We can use the existing getAllAlbums, in the future we can optimize this behavior by having a dedicated endpoint to search for albums

@TimVanOnckelen
Copy link
Author

We don't need to modify the server query. We can use the existing getAllAlbums, in the future we can optimize this behavior by having a dedicated endpoint to search for albums

fair point, i'll remove the changes and just add a filter on the frontend.

@TimVanOnckelen
Copy link
Author

I removed all server changes, the PR is now web only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants