-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Album preview overview in menu #13981
base: main
Are you sure you want to change the base?
feat(web): Album preview overview in menu #13981
Conversation
Implements part of #8743 |
Hello, thanks for the PR. I am working on migrate the whole web codebase to the new rune syntax so new features on the web will have to wait 😅 |
Np, ofcourse! Where possible, i used your changes on the rune syntax from your pr #13883 |
I will temporary set this PR back to draft until the svelte 5 migration is done. |
We don't need to modify the server query. We can use the existing getAllAlbums, in the future we can optimize this behavior by having a dedicated endpoint to search for albums |
fair point, i'll remove the changes and just add a filter on the frontend. |
I removed all server changes, the PR is now web only. |
This PR introduces a visual overview of the three latest albums in the main menu, similar to the App-Which-Must-Not-Be-Named. The addition provides quick album previews for users, enhancing navigation and user experience.
Changes Overview:
Album Menu Extension: Added a visual preview of three albums directly within the Album menu for quick access.
New Optional Parameter in API: Introduced top as an optional parameter in the /albums (getAllAlbums) route, allowing flexible limits on album retrieval.
Technical Details:
The top parameter supports optimized retrieval of album data by limiting results, enhancing efficiency for both UI rendering and API load.
The visual display integrates seamlessly with the existing menu styling, ensuring consistent user experience.