-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo and add some options #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st commit title shoud start with feat(generator/client):
3rd commit title should start with feat(generator):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on the discussion
😂 OK |
LGTM, thanks |
@@ -160,6 +163,10 @@ function generate_outbound(node) { | |||
/* Direct */ | |||
override_address: node.override_address, | |||
override_port: strToInt(node.override_port), | |||
proxy_protocol: (node.proxy_protocol === '1') ? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm according to the documentation this field aceepts a int value instead of a object, do i miss anything?
https://sing-box.sagernet.org/configuration/outbound/direct/#structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I made a mistake. The new patch has been committed
410c10e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quick fix
No description provided.