Bump Python to 3.10 #438
Merged
Bump Python to 3.10 #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Nov 4, 2024
| @@ -1478,7 +1479,7 @@ def generate_regular_rect_mesh( | |||
| "lower topological dimension and map it.)") | |||
|
|
|||
| axis_coords = [np.linspace(a_i, b_i, npoints_i) | |||
| for a_i, b_i, npoints_i in zip(a, b, npoints_per_axis)] | |||
| for a_i, b_i, npoints_i in zip(a, b, npoints_per_axis, strict=False)] | |||
There was a problem hiding this comment.
This is set to false because many tests set a = (-0.5, -0.5, -0.5) and pass the whole thing in. Not sure it's worth being very strict here..
There was a problem hiding this comment.
For now I think it's fair to capture current usage. We could add a warning later if we feel it's an issue.
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.