fix: cap the estimated screen height (#791)

influxdata · Aug 9, 2022 · e20bca5 · e20bca5
1 parent 2c3bfa4
commit e20bca5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/giraffe/package.json b/giraffe/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@influxdata/giraffe",
-  "version": "2.33.4",
+  "version": "2.33.5",
   "main": "dist/index.js",
   "module": "dist/index.js",
   "license": "MIT",

diff --git a/giraffe/src/components/SimpleTable/PagedTable.tsx b/giraffe/src/components/SimpleTable/PagedTable.tsx
@@ -277,7 +277,9 @@ const PagedTable: FC<Props> = ({result, properties}) => {
 
       timeout = setTimeout(() => {
         animationFrameID = requestAnimationFrame(() => {
-          setHeight(entries[0].contentRect.height)
+          setHeight(
+            Math.min(entries[0].contentRect.height, window.screen.height)
+          )
         })
       }, 200)
     })
@@ -289,7 +291,7 @@ const PagedTable: FC<Props> = ({result, properties}) => {
     const rect = curr?.getBoundingClientRect()
 
     if (rect && rect.height !== height) {
-      setHeight(rect.height)
+      setHeight(Math.min(rect.height, window.screen.height))
     }
 
     return () => {

diff --git a/stories/package.json b/stories/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@influxdata/giraffe-stories",
-  "version": "2.33.4",
+  "version": "2.33.5",
   "license": "MIT",
   "repository": {
     "type": "git",